[tencentcloudlogserviceexporter]Fix the specified data reporting area bug, and simplify the configuration #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After carefully checking the failed test, it seems that it has nothing to do with the PR. /ready-to-merge |
MovieStoreGuy
approved these changes
Nov 6, 2021
jpkrohling
approved these changes
Nov 8, 2021
| otlp: | ||
| protocols: | ||
| grpc: | ||
| endpoint: ":4317" |
There was a problem hiding this comment.
You don't actually need this property, as it will default to this value anyway.
There was a problem hiding this comment.
Actually, I prefer to declare the port configuration, the user may not know what the default configuration is.
| @@ -45,8 +44,8 @@ type logServiceClientImpl struct { | |||
|
|
|||
| // newLogServiceClient Create Log Service client | |||
| func newLogServiceClient(config *Config, logger *zap.Logger) (logServiceClient, error) { | |||
| if config == nil || config.TCPAddr.Endpoint == "" || config.LogSet == "" || config.Topic == "" { | |||
| return nil, errors.New("missing logservice params: TCPAddr, LogSet, Topic") | |||
| if config == nil || config.Region == "" || config.LogSet == "" || config.Topic == "" { | |||
There was a problem hiding this comment.
Could you please create an issue to move this logic to the Validate function?
|
LGTM, made a few comments that can be addressed in another PR. |
This was referenced Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug -The specified data reporting area bug, and simplify the configuration.
Link to tracking Issue:
Testing:
Documentation: